-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Extend 'short' field size support to all form inputs #5448
Comments
I believe we've been chipping away at adding these styles to additional form components right @tw15egan ? |
Great! In fact, with some digging, we did find that Text input has this feature too, just not hooked up to the storybook. For reference, our killer set of this 32px height requirement would be:
At which point I'd also like to extend this request to cover inclusion of these in the sketch library if at all possible, which if necessary we can help out with symbol creation, examples etc. |
Correct, I can go through the components and add in the functionality. For now, it will use the existing size convention of For v11 we will change these prop names to map to |
Going to close this out, as it seems like we've added the size variants to all form elements. Let me know if I missed any and I can add in that functionality. We can use #5455 to request this to be added to any other components |
Summary
Compact styling support for most form input types is available in certain components today via the 'field size prop (eg dropdown but not others, eg text input). We have proposal designs and would like to discuss collaboration on development for this in whatever manner is most appropriate.
Justification
Bringing older product sets into the world of Carbon, generally with a far more 'compact' opinion around design approach (more inputs per page, in higher density). In many of these examples, the product cannot easily re-architect the UX of many of these forms to break up the inputs into more steps easily, and are struggling with a 1-1ish mapping at the current input sizes. Allowing this compact size will greatly improve their ability to consume and work in Carbon.
Desired UX and success metrics
Essentially this is simply adding the same field size prop to all form inputs, reducing their height from 40px to 32px, eg:
Note: A naming convention should likely be applied for varying sizes. Eg: Today data table rows have 'compact', 'short' , etc. I would recommend that we extend those sizing names to any other component sizes - hence this becoming the 'short' version of inputs at 32px.
I can provide more extensive examples, sketch files with these already mocked up and in use etc if required, as well as an internal repo issue link with more extensive documentation.
"Must have" functionality
Described above - extended support of form inputs to support 'short' field sizes in both the kit and the react component library.
Specific timeline issues / requests
Timelines being defined by the primary team in our unit that has these as a requirement. Like with everything, always, the sooner the better.
Available extra resources
The IoT PAL team has a number of development resources working to support requests like these on its own timeline. Naturally when this requirement becomes 'due' we would like to ensure we are able to do this with core Carbon, rather than in the IoT PAL. CC @davidicus
The text was updated successfully, but these errors were encountered: