Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structured-list): Add React component support for the condensed structured list styles #5736

Closed
zJag opened this issue Mar 27, 2020 · 1 comment · Fixed by #8446
Closed

Comments

@zJag
Copy link

zJag commented Mar 27, 2020

Summary

The carbon-components repo has styles for a condensed structured list using the class {prefix}--structured-list--condensed. The React component StructuredListWrapper should have a prop that toggles this class, similar to how there are props to change the sizing of Button and DataTable.

The styles can currently be added by manually including the class under the className prop.

Justification

Since carbon-components have the styles, it should be supported in carbon-components-react.

Desired UX and success metrics

A user can set a prop to toggle the class on the StructuredListWrapper.

"Must have" functionality

An easy way to add the condensed class to the React component.

Specific timeline issues / requests

As there is a workaround to add this feature, there is no specific timeline.

Available extra resources

I've added this feature in my forked carbon repo already. I will be able to submit a PR to add this feature.

@asudoh
Copy link
Contributor

asudoh commented Mar 28, 2020

Hi 👋 seems that adding that support makes sense, unless our designer considers that mode is a legacy one. CC @carbon-design-system/design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants