Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle and ToggleSmall Skeleton broken #6222

Closed
2 tasks done
richardpilot opened this issue Jun 8, 2020 · 1 comment · Fixed by #9918
Closed
2 tasks done

Toggle and ToggleSmall Skeleton broken #6222

richardpilot opened this issue Jun 8, 2020 · 1 comment · Fixed by #9918
Labels
component: toggle package: components carbon-components package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@richardpilot
Copy link

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

The skeleton for ToggleSmall appears to be broken. It looks identical to a ToggleSmall without any props and doesn't show the typical animated skeleton. Additionally it doesn't provide a smaller skeleton for the label like TextInput

https://react.carbondesignsystem.com/?path=/story/togglesmall--skeleton
@emyarod
Copy link
Member

emyarod commented Jun 8, 2020

it doesn't seem like the toggle skeleton has changed much since it was introduced, cc @carbon-design-system/design is there a spec for this skeleton component?

@joshblack joshblack added component: toggle package: components carbon-components package: react carbon-components-react labels Jun 15, 2020
@joshblack joshblack self-assigned this Jun 15, 2020
@joshblack joshblack added impact: high 😱 severity: 2 https://ibm.biz/carbon-severity labels Jun 15, 2020
@joshblack joshblack removed their assignment Aug 4, 2020
@laurenmrice laurenmrice mentioned this issue Mar 19, 2021
Closed
86 tasks
@joshblack joshblack mentioned this issue Apr 5, 2021
Closed
@jnm2377 jnm2377 mentioned this issue Apr 16, 2021
Closed
@jnm2377 jnm2377 mentioned this issue Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: toggle package: components carbon-components package: react carbon-components-react severity: 2 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
3 participants
@joshblack @emyarod @richardpilot