Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification] investigate deprecating actions from toast #6433

Closed
aagonzales opened this issue Jul 9, 2020 · 5 comments
Closed

[notification] investigate deprecating actions from toast #6433

aagonzales opened this issue Jul 9, 2020 · 5 comments
Labels
component: notification hacktoberfest See https://hacktoberfest.com/ proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: a11y ♿

Comments

@aagonzales
Copy link
Member

Summary

Actions inside of toast notifications have been found to not be WCAG 2.1 compliant.

We need to clearly document why why they are not accessible and if there are any acceptable solutions (ie notifications collect and available in accessible area).

If we do not want to support any scenario that includes an action in toast then we need to full deprecate "action" in toast notification. (V11 or sooner?)

If we want accept the available in accessible area solution then we need to clear document this as the only why to have an action.

References

  • The following is the passage on the notification usage page that needs clarification and decision.

Action
Carbon toast notifications are not fully accessible when they include interactive content. Using links and other interactive content in toasts breaks WCAG 2.1 compliance and should therefore be avoided. The Carbon team is aware of the accessibility concerns and is currently working on deprecating this functionality.

@aagonzales aagonzales added type: enhancement 💡 proposal: open This request has gone through triaging. We're determining whether we take this on or not. component: notification type: a11y ♿ and removed type: enhancement 💡 labels Jul 9, 2020
@aagonzales
Copy link
Member Author

Example of persistent toast
image

@aagonzales
Copy link
Member Author

aagonzales commented Aug 14, 2020

Questions to answer.

  • need to build a non-modal dialog notification?
  • if so does it still need to live in a drawer somewhere?

@aagonzales aagonzales added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Aug 14, 2020
@vpicone
Copy link
Contributor

vpicone commented Aug 15, 2020

We can just disable the timeout dismissal when actions are provided. I talk about it in my issue here #5055

@tw15egan tw15egan added hacktoberfest See https://hacktoberfest.com/ and removed hacktoberfest See https://hacktoberfest.com/ labels Sep 29, 2020
@tombrunet
Copy link
Contributor

To add our +1: We were confused by the deprecation note. We're assuming this is due to the guidance to automatically dismiss. The React component leaves that under the control of the developer and does not automatically dismiss as-is. Is there something else causing issues?

@dakahn
Copy link
Contributor

dakahn commented Jun 25, 2021

closing this out since we've moved forward with notification/toast v11 refactor and guidance 👍🏽

@dakahn dakahn closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: notification hacktoberfest See https://hacktoberfest.com/ proposal: accepted This request has gone through triaging and we are accepting PR's against it. type: a11y ♿
Projects
None yet
Development

No branches or pull requests

5 participants