-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] sketch plugin has bug issues #6485
Labels
Comments
50 tasks
1 task
38 tasks
This was referenced Jan 20, 2021
after #7648 it seems that new icons are being added on sync, WIP still under way on the sync itself skewing icons as well as removing deprecated icon symbols and artboards |
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
While doing a test with the latest sketch plugin I noticed that some icons are rendering incorrectly by skewing their proportions.
We originally thought that this was only happening to icons that did not have a transparent rectangle layer applied to them in their svgs, but that is not the case. This is also happening to icons that do have the transparent rectangle.
I made an audit here of the icons this is happening to for each size and if there is a transparent rectangle or not. I also addressed when they are being put into a new file vs rendered onto an existing id.
https://www.notion.so/carbondesignsystem/Rendering-problems-c85a5d53e45b4716b6b1bb6a1776c4ea
In addition to the rendering issues the following problems are also happening:
Deprecated icons: Resolved by feat(sketch): remove deprecated icons from sketch plugin #8060
-The plugin is not deleting the deprecated icon artwork/artboards out of the sketch library
Editing existing icons: Resolved by fix(sketch): resolve icon sync artwork issues #7711
-If an existing icon on artboard is edited in the code svg asset, the update the library receives changes the size of the edited icon but skews the original artwork.(it does not replace the artwork with the new artwork version) [icons] rendering problems with sketch #5758 [icons] icon bugs generated into sketch by plugin #5749 Evaluate 16, 20 and 24 icons for redundancy #5597
Brand new icons: Resolved by fix(sketch): resolve icon sync artwork issues #7711
-Artwork and artboards import fine with correct naming 👍🏻 Add new icon assets to icon library when syncing in Sketch plugin #7712
-Attached colors for new icons are coming in differently than the existing ones. They are both black but are coming from different places. (Can we get them all to have the same attached color style? And can we decide where it connects to?)
The text was updated successfully, but these errors were encountered: