-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAWS doesn't read combobox using Arrow keys #7341
Comments
Hi @dakahn, I used Insert+Down Arrow key to let jaws read the page content automatically (without using Tab key to move the focus), and below is my jaws output: |
Can you confirm that the options are read and accessible by JAWS at all with your setup? @carmacleod what is the expectation here for JAWS's automatic page reading regarding a combobox? The title is being read, but not the options -- which makes sense to me, but there could be something i'm missing. |
I didn't do any specific setup in my jaws, just using the default setup.
For those users with visual impairments, hope to understand the screen content through jaws reading. If jaws reads content in order but cannot read the combobox, users will not be aware that there is combobox for operation. |
I would expect the combobox to be read but not the options. Right now, it is only reading the label. I would expect it to say: But it isn't reading the "edit combo" part. Not sure why. Sorry, I am out of time to look at this in any more depth, but maybe you can compare it to one of the APG combos: heading level 2 Example |
I totlely agree with @carmacleod. |
Although not ideal our current Combobox reads "combobox, edit has popup, {selection or placeholder}, type and text" Which seems to sufficiently describe that the component is a combobox that is editable, its current selection or placeholder, and that on edit a popup will trigger. This is an improvement on what I was seeing previously where the editable nature of the Combobox wasn't described at all. I'm going to close since the core issue was resolved. That said we have further improvements to make can track further changes to Combobox in the 1.2 update issue here. |
Hi @dakahn, sorry I am not quite clear about your process.. can you tell me when and how I can verify the issue? waiting for the new release v10.28.0 or even later? |
@xiepingp In testing the menu items are sufficiently read as expected and when expected. You can verify this yourself by testing against our latest sandbox seen here and then update accordingly. If you feel like this is insufficient link me to WAI-Aria spec that details what we're missing and I can reopen. |
@dakahn, I tested in https://react.carbondesignsystem.com/?path=/story/combobox--combobox (v7.28.0), jaws is still read the title only: |
Hi @xiepingp! 👋 The fix will be included in our next release (v10.29.0) which you can preview over at: https://carbon-components-react.netlify.com/ |
Thanks for the infomation @joshblack 😄 |
@joshblack You said you could not repro, could you please attach your speech history? And your Jaws version? |
@mashenka123 thanks for reaching out! @dakahn can confirm the steps that he used for verifying it earlier 👀 |
@xiepingp Spent a good bit of my afternoon looking into this. I can confirm this behavior is still present. I used the WAI-Aria Combobox as a control in my testing. That said I have two points: First I'm just not convinced it's an implementation problem on the our side. Inspecting and comparing the markup between our example and the WAI-Aria example doesn't reveal any meaningful differences (at least to my eyes). Even closer inspection of the accessibility tree shows us that to a screen reader our combobox is marked up and should be understood like we'd expect, with good semantics and proper programmatic labeling. Secondly, This is an interesting use case -- for both the aforementioned screen readers With that said 😩 I would still expect the combobox to be read with |
@dakahn This is blocking Code Engine eGA, could you please let me know the fix plan? Thank you! |
@mashenka123 @dakahn The APG link that you were using to test combobox uses the older ARIA 1.1 pattern, which never did work well with screen readers. That is why Carbon needed to upgrade to the ARIA 1.2 pattern. |
This is blocking Kubernetes bug fix for: https://github.ibm.com/alchemy-containers/armada-ui/issues/6087 |
@mashenka123 |
Environment
Windows
Latest Chrome
IBM CI 162 Checkpoint Violation: IBM 1.3.1 Info and Relationships
IBM Guidance: https://www.ibm.com/able/guidelines/ci162/info_and_relationships.html
Test Tool Type: JAWS Screen Reader 2019
Detailed description
When JAWS reads the page content in order automatically, it wll not read the combobox.
And the combobox cannot receive the focus via pressing Arrow key, unless I use Tab key.
carbon-components-react@7.24.0
Jaws can read the combobox automatically in order.
And the combobox can receive the focus via pressing Arrow key
JAWS does not read the combobox.
The combobox cannot receive the focus via Arrow key.
IBM CI 162 Checkpoint Violation: IBM 1.3.1 Info and Relationships
Steps to reproduce the issue
Use JAWS to read page content. See description above.
Use storybook here:
https://react.carbondesignsystem.com/iframe.html?id=combobox--combobox
Additional information
The text was updated successfully, but these errors were encountered: