Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUploader breaks Modal's UI when clicked #7343

Closed
1 task
bitfede opened this issue Nov 25, 2020 · 5 comments
Closed
1 task

FileUploader breaks Modal's UI when clicked #7343

bitfede opened this issue Nov 25, 2020 · 5 comments

Comments

@bitfede
Copy link

bitfede commented Nov 25, 2020

What package(s) are you using?

  • carbon-components
  • [x ] carbon-components-react

Detailed description

Describe in detail the issue you're having.

I want to have a fileuploader inside a modal window. The problem is that when I click on fileuploader the modal's UI breaks by shifting to the top and disabling scrolling.

Is this issue related to a specific component?

Yes, Modal and FileUploader

What did you expect to happen? What happened instead? What would you like to
see changed?

I expected for the modal to keep the same layout, but when FileUploader is pressed it moves up the whole modal content suddenly.

What browser are you working in?

Chrome

Additional information

Screenshots:

before clicking on fileuploader:
Screen Shot 2020-11-25 at 4 08 43 AM

after clicking on fileuploader (right after dismissing the window that lets me pick the files to upload):
Screen Shot 2020-11-25 at 4 08 30 AM

What can it be? Any suggestion? Anyone ever had this problem?

Thanks for your time!!!

@edurocher
Copy link

We had something similar and other problems since Chrome updated to version 87. I suspect this has to do with the .bx--visually-hidden styles (it is used in the file uploader component). It looks like Chrome changed something in the implementation of positioned elements.
Absolutely no guarantee but can you try this? It solved related problems for me:

.bx--visually-hidden {
  left: -999px;
}

@bitfede
Copy link
Author

bitfede commented Nov 25, 2020

Hey @edurocher thank you very much for your time! Unfortunately that CSS rule didn't fix the issue, but you gave me some good insight into what to try and what might be going on.

I'll keep troubleshooting in the meantime

@tw15egan
Copy link
Collaborator

Related #7340

@tw15egan
Copy link
Collaborator

tw15egan commented Feb 4, 2021

Hey there @bitfede! Looks like this was resolved in the latest release 7.28.0/10.28.0 (via #7698)

Updated example: https://codesandbox.io/s/modest-buck-81lj0?file=/index.js

@tw15egan tw15egan closed this as completed Feb 4, 2021
@bitfede
Copy link
Author

bitfede commented Feb 8, 2021

Thanks for letting me know! Good Job guys! 💪💪💪💪💪💪💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants