Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author CSS Grid Components for React #8142

Closed
joshblack opened this issue Mar 22, 2021 · 0 comments · Fixed by #8411
Closed

Author CSS Grid Components for React #8142

joshblack opened this issue Mar 22, 2021 · 0 comments · Fixed by #8411
Assignees
@tay1orjones
Labels
package: react carbon-components-react type: enhancement 💡
Milestone
2021 Alpha Release

Comments

@joshblack
Copy link
Contributor

We currently offer support for Grid, Row, and Column components in carbon-components-react. With our new CSS Grid support, we will need to either update these components or add variants to work with our CSS Grid classes.

Most likely we should see if we can make use of existing Grid and Column components (Row is no longer needed), potentially behind a feature flag that is added to our new @carbon/feature-flags package. These components should use the class names that were authored for the new CSS Grid support.
@joshblack joshblack changed the title Write CSS Grid Components for React Author CSS Grid Components for React Mar 22, 2021
@joshblack joshblack mentioned this issue Mar 22, 2021
Closed
86 tasks
@joshblack joshblack added this to the 2021 Alpha Release milestone Mar 22, 2021
@tay1orjones tay1orjones self-assigned this Mar 24, 2021
@joshblack joshblack mentioned this issue Apr 5, 2021
Closed
This was referenced Apr 14, 2021
Closed
Merged
@kodiakhq kodiakhq bot closed this as completed in #8411 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tay1orjones tay1orjones

Labels
package: react carbon-components-react type: enhancement 💡
Projects
None yet
Milestone
2021 Alpha Release
Development

Successfully merging a pull request may close this issue.

feat(grid): add css-grid support to components behind a feature flag tay1orjones/carbon
2 participants
@tay1orjones @joshblack