-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time picker vs Date range picker - spacing #8234
Comments
based on #6265 the spacing is intentional, cc @laurenmrice for confirmation |
bump @laurenmrice when you get a sec! |
I did not realize they were different from each other. After talking as a group with design, we have decided to keep a |
Thanks @laurenmrice! Going to close this out since it seems like the question was addressed 👀 |
@emyarod just a quick heads up, when you get a sec make sure that issues being tackled are added to the sprint/sized! I went ahead and did a rough pass for this one, feel free to update if I'm off! |
We are exploring a custom field type which is a compound of a Text input + Select components. In Carbon there are two similarly constructed components - "Time picker" and "Date range picker".
I wanted to double check what should be the spacing between the two components - 1px or 2px? I noticed the spacing is not consistent in the following Sketch library assets:
The text was updated successfully, but these errors were encountered: