Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time picker vs Date range picker - spacing #8234

Closed
ivanbachev opened this issue Mar 30, 2021 · 5 comments · Fixed by #8304
Closed

Time picker vs Date range picker - spacing #8234

ivanbachev opened this issue Mar 30, 2021 · 5 comments · Fixed by #8304

Comments

@ivanbachev
Copy link

We are exploring a custom field type which is a compound of a Text input + Select components. In Carbon there are two similarly constructed components - "Time picker" and "Date range picker".

I wanted to double check what should be the spacing between the two components - 1px or 2px? I noticed the spacing is not consistent in the following Sketch library assets:

Time picker vs Date range picker - spacing@2x

@emyarod
Copy link
Member

emyarod commented Mar 30, 2021

based on #6265 the spacing is intentional, cc @laurenmrice for confirmation

@joshblack
Copy link
Contributor

bump @laurenmrice when you get a sec!

@laurenmrice
Copy link
Member

I did not realize they were different from each other. After talking as a group with design, we have decided to keep a 1px space instead of 2px. This follows the same spacing we have for the condensed grid gutter.

@joshblack
Copy link
Contributor

Thanks @laurenmrice! Going to close this out since it seems like the question was addressed 👀

@joshblack
Copy link
Contributor

@emyarod just a quick heads up, when you get a sec make sure that issues being tackled are added to the sprint/sized! I went ahead and did a rough pass for this one, feel free to update if I'm off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants