Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show/hidePasswordLabel in TextInput.ControlledPasswordInput do nothing (tooltip always shows default values) #8359

Closed
1 of 2 tasks
twgoetz opened this issue Apr 12, 2021 · 0 comments · Fixed by #8363
Closed
1 of 2 tasks

Comments

@twgoetz
Copy link

twgoetz commented Apr 12, 2021

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

When using the showPasswordLabel/hidePasswordLabel props on TextInput.ControlledPasswordInput, they have no effect. Instead, the default text of "Show password"/"Hide password" is always shown. This can be seen in the storybook as well. The corresponding knobs have no effect.

Is this issue related to a specific component?

Yes

What did you expect to happen? What happened instead? What would you like to
see changed?

What browser are you working in?

chrome, but I don't think it's browser specific :)

What version of the Carbon Design System are you using?

10.31.0

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

Steps to reproduce the issue

  1. Go here: https://react.carbondesignsystem.com/?path=/story/components-textinput--fully-controlled-toggle-password-visibility
  2. Try changing the "Hide password" tooltip label for password visibility toggle (hidePasswordLabel) label
  3. Observe that the eye icon tooltip does not change

Please create a reduced test case in CodeSandbox

Additional information

  • Screenshots or code
  • Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants