Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password Text Input icon not receiving disabled colors #8375

Closed
tw15egan opened this issue Apr 12, 2021 · 2 comments · Fixed by #8528
Closed

Password Text Input icon not receiving disabled colors #8375

tw15egan opened this issue Apr 12, 2021 · 2 comments · Fixed by #8528
Assignees
@emyarod
Labels
component: text-input role: dev 🤖 type: bug 🐛

Comments

@tw15egan
Copy link
Member

tw15egan commented Apr 12, 2021 •
edited
Loading

Noticed while working on #8303

Screen Shot 2021-04-12 at 3 38 41 PM

When disabled, the eye icon is not getting disabled styles due to a more specific selector setting the fill.

We need to either reduce the specificity of the linked selector (ideal) or increase the specificity for the disabled styles
@tw15egan tw15egan changed the title Password Text Input Password Text Input icon not receiving disabled colors Apr 12, 2021
@emyarod
Copy link
Member

emyarod commented Apr 13, 2021

should I roll this into #8368?

@tw15egan
Copy link
Member Author

@emyarod sounds good to me 👍🏻

@emyarod emyarod self-assigned this Apr 27, 2021
@emyarod emyarod mentioned this issue Apr 28, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #8528 May 4, 2021
@emyarod emyarod mentioned this issue May 17, 2021
Closed
94 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: text-input role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(text-input): increase disabled password toggle specificity emyarod/carbon
2 participants
@emyarod @tw15egan