Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Component Magnifier Icon Has Mixed Class Selectors #8460

Closed
sjbeatle opened this issue Apr 20, 2021 · 3 comments
Closed

Search Component Magnifier Icon Has Mixed Class Selectors #8460

sjbeatle opened this issue Apr 20, 2021 · 3 comments

Comments

@sjbeatle
Copy link
Contributor

The latest version of carbon components (10.33.0) uses the following two selectors interchangeably in various areas of the CSS:
bx--search-magnifier
bx--search-magnifier-icon

The latest version of carbon angular components (4.48.2) and carbon react components (7.2.0) uses bx--search-magnifier, which worked correctly since at least carbon components 10.21.0 but is now broken in 10.33.0.

Either carbon components will need to align on a single selector, or the framework libraries will need to update to accommodate both:

Any questions, please feel free to reach out. Thank you!

@tw15egan
Copy link
Collaborator

Rel #8101

@tw15egan
Copy link
Collaborator

tw15egan commented Jun 1, 2021

I believe the easiest course of action would be for the Angular team to update the selector to bx--search-magnifier-icon. Normally, we reference both the old and new selectors in the styles and mark the old selector for removal in the next major release. This one seems like it slipped through the cracks. Going to transfer over to the Angular repo

@tw15egan
Copy link
Collaborator

tw15egan commented Jun 1, 2021

Will be tracked in this issue: carbon-design-system/carbon-components-angular#1821

@tw15egan tw15egan closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants