Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Optional prop to remove hover shadowing in DataTable component #9856

Closed
1 task done
sydrosa opened this issue Oct 13, 2021 · 2 comments
Closed
1 task done
Labels
proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. type: enhancement 💡

Comments

@sydrosa
Copy link

sydrosa commented Oct 13, 2021

Summary

With DataTable component being able to render so many different types of data/information/components in it's table cells, I'd suggest being able to remove the hover shadow on each row for styling purposes. This may involve both design and development.

Justification

Currently, there is no business reason for this request.

I believe that this may make development easier as the CSS overrides to achieve this behavior were a bit difficult (the hover state is on both the row and cell).

In a prototype I'm currently working with, a column inside the data table has cells which are full of <Code> snippet components. When you hover over the row/cell, the snippet remains with the white background, since the "Copy" action button inside of it also has a background transition hover state (the same color as the row/cell's hover state). I can imagine many other scenarios where you're rendering a component in the cell, which does not work nicely with the hover state.

Desired UX and success metrics

This I'm less sure about, since this enhancement can be achieved with CSS overrides. I imagine that removing a hover state out of the box for devs who are rendering components in each cell will increase correct implementation.

Required functionality

An optional prop (defaulted as true) that will remove the hover class on both the row and cell in DataTable component.

Specific timeline issues / requests

None currently. Just wanted to see if this was possible :)

Available extra resources

No response

Code of Conduct

@tay1orjones tay1orjones added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Oct 14, 2021
@theiliad
Copy link
Member

theiliad commented Dec 6, 2021

@sydrosa thanks for opening this issue 👋🏻

You should be able to achieve this by overriding the CSS.

We won't be adding the functionality into the library just yet as we think that we might be losing usability.

@theiliad theiliad added proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Dec 6, 2021
@theiliad
Copy link
Member

theiliad commented Dec 6, 2021

Feel free to reopen with additional comments 🙂

@theiliad theiliad closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: not pursuing This has gone through triaging and because of priorities or mission, we will not be pursuing this. type: enhancement 💡
Projects
Archived in project
Development

No branches or pull requests

4 participants