Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sketch): fetch default icon layer styles from IDL Sketch library #8188

Closed
wants to merge 6 commits into from
Closed

fix(sketch): fetch default icon layer styles from IDL Sketch library #8188

wants to merge 6 commits into from

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 25, 2021 •
edited
Loading

Closes #8127

This PR connects the default icon shared layer styles to the IDL V2 Sketch library instead of regenerating them in the document. The icons sync command is now no longer dependent on the colors sync command or @carbon/colors

Changelog

New

  • link icon shared layer styles to IDL V2 Sketch library

Changed

  • decouple icons sync command from colors sync command
  • use param objects for icon sync functions and helpers

Testing / Reviewing

Confirm that icon layer shared styles are linked to the IDL V2 Sketch library when syncing icons

carbon-elements.sketchplugin.zip

carbon-elements.sketchplugin.zip

carbon-elements.sketchplugin.zip

@emyarod emyarod requested a review from a team as a code owner March 25, 2021 18:53
@netlify
Copy link

netlify bot commented Mar 25, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 04eac12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e46ad7b568e000078869d1

😎 Browse the preview: https://deploy-preview-8188--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 25, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 04eac12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e46ad7df089500077b4f57

😎 Browse the preview: https://deploy-preview-8188--carbon-components-react.netlify.app

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 2 times, most recently from d76d9b2 to 7b24437 Compare March 31, 2021 15:48
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2021 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from 7b24437 to 6936539 Compare March 31, 2021 20:29
@emyarod
Copy link
Member Author

emyarod commented Mar 31, 2021

currently investigating a recent Sketch update which may be causing a new issue across the board for our plugin (unrelated to this PR or previous plugin PRs)

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from 6936539 to cc06c51 Compare April 1, 2021 15:09
@emyarod emyarod mentioned this pull request Apr 1, 2021
Closed
86 tasks
@joshblack joshblack mentioned this pull request Apr 5, 2021
Closed
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 2 times, most recently from 351edd7 to a60d811 Compare April 9, 2021 15:20
@emyarod
Copy link
Member Author

emyarod commented Apr 9, 2021

upstream issue may be resolved by 71.2

image

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from a60d811 to 2e18afc Compare April 13, 2021 15:26
@emyarod
Copy link
Member Author

emyarod commented Apr 13, 2021

upstream issue does not appear to be resolved by 71.2, more investigation needed

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 3 times, most recently from c7c4212 to fcb96f6 Compare April 16, 2021 16:40
@joshblack joshblack mentioned this pull request Apr 19, 2021
Closed
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from fcb96f6 to 46d5a2d Compare April 21, 2021 15:07
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 3 times, most recently from 4d98795 to 05211ed Compare April 29, 2021 15:29
@joshblack joshblack mentioned this pull request May 3, 2021
Closed
94 tasks
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 2 times, most recently from a3125c7 to f25f272 Compare May 10, 2021 16:29
laurenmrice
laurenmrice approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are now attached to IDL v2 library layer styles and color variables. 👍 ✅

@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from f25f272 to 5fa38b4 Compare May 13, 2021 21:36
@joshblack joshblack mentioned this pull request May 17, 2021
Closed
87 tasks
@emyarod emyarod mentioned this pull request May 17, 2021
Merged
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch 3 times, most recently from ca5c1ec to b42c736 Compare May 24, 2021 15:35
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from b42c736 to 848a338 Compare May 26, 2021 18:59
@emyarod emyarod mentioned this pull request Jun 3, 2021
Closed
85 tasks
@joshblack joshblack mentioned this pull request Jun 14, 2021
Closed
@emyarod emyarod force-pushed the 8127-connect-icon-colors-to-idl-v2-library branch from 848a338 to 04eac12 Compare July 6, 2021 14:38
@netlify
Copy link

netlify bot commented Jul 6, 2021 •
edited
Loading

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: 04eac12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f597bedbe39841dd2bbc4f

@emyarod emyarod closed this Aug 18, 2021
@emyarod emyarod deleted the 8127-connect-icon-colors-to-idl-v2-library branch August 30, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@andreancardona andreancardona andreancardona approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: blocked 🙅‍♀️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[icons] connect icon color to idl v2 library
4 participants
@emyarod @joshblack @andreancardona @laurenmrice