fix(modal): add safari media query for overflow indicator #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 6866e28 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 6866e28 https://deploy-preview-8510--carbon-components-react.netlify.app |
jnm2377
approved these changes
May 4, 2021
jnm2377
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in #8495 (comment)
This PR separates Safari specific modal overflow indicator styles into a media query, in line with the implementation in code snippet and tabs
Testing / Reviewing
Confirm the modal overflow indicator appears correct when the
hasScrollingContentprop is enabled