fix(sketch): avoid repositioning preexisting icon artboards #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
May 10, 2021
|
Deploy preview for carbon-elements ready! Built with commit 0cde748 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0cde748 https://deploy-preview-8639--carbon-components-react.netlify.app |
andreancardona
approved these changes
May 11, 2021
laurenmrice
approved these changes
May 11, 2021
emyarod
force-pushed
the
8569-sketch-artboard-repositioning-bug
branch
from
d50fbf2
to
db5e8a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8569
This PR prevents icon artboards from shifting during syncs if there is a preexisting artboard for a given icon.
Testing / Reviewing
Confirm that there are no regressions and that icon artboards do not shift position after running the icons sync command
carbon-elements.sketchplugin.zip