-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(PasswordInput): resolve visibility toggle style issues #8673
fix(PasswordInput): resolve visibility toggle style issues #8673
Conversation
Deploy preview for carbon-elements ready! Built with commit f055883 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
Deploy preview for carbon-components-react ready! Built with commit f055883 https://deploy-preview-8673--carbon-components-react.netlify.app |
@emyarod the focus border looks like the right size/position! Just wondering if the icon focus border should be disabled when text input is disabled? If this isn't a problem or if it's something that would better be addressed in a separate PR, let me know and I'll go ahead and approve these changes. Thanks! Screen.Recording.2021-05-13.at.8.21.13.AM.mov |
@johnbister that issue is resolved in #8368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
f6f77f1
to
f055883
Compare
Closes #8672
This PR restores the focus outline to the password input visibility toggle button and properly positions it for all component size variants
Testing / Reviewing
Verify that the focus border appears as expected on the password input visibility toggle and that it is properly sized and aligned in all size variants of the component