feat: update switcher content #1023
Conversation
jnm2377
requested review from
jeanservaas,
a team,
vpicone and
sstrubberg
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/4s9ez6fu4 |
|
@jeanservaas @janchild I'll defer are we moving forward with this structure? |
|
@vpicone seems like @mjabbink said yes: #984 (comment) |
There was a problem hiding this comment.
@jnm2377 Sorry that the links weren't included in the issue.
The only change is that we want the IBM Design link (with the lock next to it) under Community to link to the internal W3 IBM Design site, not the external one. That's why we put that lock there because it is behind a login. I will be right back with the link to that site and add it here.
here we go:
w3.ibm.com/design
…rbon into switcher-content
|
@jeanservaas updated the design link. What about the brand center link? That one also has a lock on it. But it's a public link. Is that right? |
|
@jnm2377 this is out of scope, but I just noticed the Switcher toggle button is doing a weird pulse when clicked could you see if it might be an easy add on here? |
It's public, but it's tucked behind IBMid. If you don't have an IBMid account, you won't be able to access the site. |
|
@jeanservaas @janchild I also think moving Community to the bottom makes more sense to me. |
|
Also noting the change to We can update the name in the switcher to be “Carbon for IBM.com” |
|
@mjabbink @jeanservaas updated! |
|
@jnm2377 Sorry for the delay, we were shopping a few things around. This is the new, final order... per Mike's comment, we moved community now to the bottom
|
|
@jeanservaas and @jnm2377 The above image is not correct —> “IBM.com Library” should be “Carbon for IBM.com” |
|
@jnm2377 Were you able to address this bug #1023 (comment) in this issue? |
|
@mjabbink I went by this comment #1023 (comment) You can see the changes in the deployed preview |
|
Is your preview not updating? bc it doesn't say IBM.com Library anymore |
|
lord, don't hate me, one more change. We need to put IBM iX back into "Practices" at the moment. Not everyone was cool with removing it and I don't want it to hold us up. Here is the link that goes with iX:
|
|
@jnm2377 I see the updates other than the last from Jeannie. All good other than that one. |
|
@jnm2377 I am so sorry for all this confusion. Some updates were made to the original issue about the IBM.com library name change that I missed because I was only looking here. Apparently, now that they've changed their name, we're moving forward with it in the app switcher: This is the final verified by @mjabbink and @janchild I am updating it the issue too. The links for iX is: The link for Carbon for IBM.com is:
|
|
@jnm2377 @jeanservaas Looking good. Only need to add iX back into Practices. |
|
@jeanservaas @mjabbink added back iX, should be available to review after the new preview finishes building 👍 |
|
@jnm2377 This is looking good. One thing I noticed is that the URL for Carbon for IBM.com is using the redirect. Their new URL is It doesn't matter because they do have a redirect, but just thought I'd mention in case you wanted to put the new URL in instead. |
|
@janchild thanks! just updated the link 👍 |
|
Looks great @jnm2377 |
Closes #984
32px(attaching a picture at the bottom) so I didn't change itreviewers