Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ordered list styles in firefox #1047

Merged
merged 2 commits into from
Nov 3, 2020
Merged

fix: ordered list styles in firefox #1047

merged 2 commits into from
Nov 3, 2020

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Nov 2, 2020

Closes #949

Changelog

  • updates ordered list with new carbon style for native lists

Reviewers

  • test in firefox browser, compare deployed preview to the live gatsby site (where numbers start incorrectly), check that numbers are starting correctly now

@jnm2377 jnm2377 requested review from a team, vpicone and sstrubberg and removed request for a team November 2, 2020 16:34
@vercel
Copy link

vercel bot commented Nov 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/e8mhu9doa
✅ Preview: https://gatsby-theme-carbon-git-fix-ol.carbon-design-system.vercel.app

alisonjoseph
alisonjoseph approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! looks great 🔥

@sstrubberg sstrubberg merged commit eae9688 into carbon-design-system:main Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@vpicone vpicone Awaiting requested review from vpicone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List acting up in Firefox. Numbering continues rather than starting from 1 on second list
3 participants
@jnm2377 @alisonjoseph @sstrubberg