-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement[card]: add 1:1 card to component library #1061
Comments
@jeanservaas @vpicone moved this to Brand priority. We should get this into upcoming sprints |
@jeanservaas Let’s connect with Vince on these two issues |
@jeanservaas using a % from the padding seems counter to other component style approaches. Is there a reason to not use a static value from the spacing scale? |
@vpicone I think the spacing strategy is up to you and the intent is that the content does not extend to the far right margin so the additional padding (however it’s done) prevents that from happening. I think @jeanservaas mentioned % because I think we all understand that is how the main body copy is done so the text does not fully span 8 columns. |
SquareCard |
@DianaStanciulescu I think this type of usage with 14px label over 28px is good to have and is currently used on the Carbon for IBM.com page https://www.ibm.com/standards/carbon/#latest-updates |
@mjabbink I added this one to the specs. I also noticed we had an open issue regarding leading for productive heading 3: I think Jeannie was thinking about having a "long" option for it, at 20/28 type. |
Enhancement: the 1:1 Card
@DianaStanciulescu is currently updating the Gatsby kit and there are several high priority component enhancements that we would like to add to our Gatsby component library.
The specs are below, so this is solely a dev work stream that's needed.
Justification
Although the 1:1 card with no image is being used widely in Gatsby sites and in product, it does not exist as a component. As a result teams need to modify the 1:1 image component to achieve this card, but more importantly, they don't understand type hierarchy in this card. Offering type hierarchy variants alone with drastically decrease support questions for Gatsby theme.
Some use cases:
https://www.ibm.com/able/
https://www.ibm.com/able/toolkit
https://www.ibm.com/design/thinking/page/courses/Practitioner
https://www.ibm.com/design/thinking/page/toolkit
https://www.ibm.com/design/research/guiding-principles/principles-overview
https://www.ibm.com/standards/web/carbon-for-ibm-dotcom/
Design specs and variants
Ideally this card configuration can work with an H2 title or an H3 title.
The is an enhancement of the image component so grid behavior is exactly the same as it is for that component.
Sketch file attached
1:1 Card Specs.zip
This is a brand prioritized issue so that Diana's kit matches what is available in the code
The text was updated successfully, but these errors were encountered: