fix(page-tabs): nav aria unique labels

[andreancardona]

Closes issue found on carbon website - from theme:

• audit-avt1-designing-design-kits: more than one nav role carbon-website#1554
• audit-avt1-tabs: multiple nav roles need unique labels carbon-website#1716

Changed
Added. unique aria labels for tabs

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/44z1e8mp3
✅ Preview: https://gatsby-theme-carbon-git-1716-avt1-tabs-multiple-nav-roles.carbon-design-system.now.sh

[vpicone]

I'm not sure the currentTab makes for a good label. It's not like an ID or key where we just need it to be unique. For instance here the navigation is named sidebar. If you change the tab (to tabs) then the label changes to just tabs.

I wonder if using parent would be more appropriate so the label stays the same for that nav element between tabs (probably Navigation)

[andreancardona]

I'm not sure the currentTab makes for a good label. It's not like an ID or key where we just need it to be unique. For instance here the navigation is named sidebar. If you change the tab (to tabs) then the label changes to just tabs.

I wonder if using parent would be more appropriate so the label stays the same for that nav element between tabs (probably Navigation)

okay! so changing this to aria-label="navigation" am I understanding that corrrectly? @vpicone

[vpicone]

@andreancardona sorry it's kinda confusing/meta with these pages haha.

As a different example, the label here would be color: https://www.carbondesignsystem.com/guidelines/color/overview/

(Not overview, usage and code)

[andreancardona]

@andreancardona sorry it's kinda confusing/meta with these pages haha.

As a different example, the label here would be color: https://www.carbondesignsystem.com/guidelines/color/overview/

(Not overview, usage and code)

ahh makes a lot more sense just pushed. up a fix @vpicone