Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update package.json scripts for npm users #1103

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

sydrosa
Copy link
Contributor

@sydrosa sydrosa commented Mar 8, 2021

The script for dev:clean is currently yarn build && yarn clean or something like this.

If a user is utilizing npm as a package manager instead of yarn, or don't have yarn installed on their machine, they will continue to see error when running npm run dev:clean.

Changelog

New

  • Updated package.json avail scripts for npm users

Changed

  • dev:clean points to gatsby clean && gatsby develop -H 0.0.0.0

Removed

  • removed yarn clean && yarn dev from dev:clean

The script for `dev:clean` is currently `yarn build && yarn clean` or something like this. 

If a user is utilizing npm as a package manager instead of yarn, or don't have yarn installed on their machine, they will continue to see error when running `npm run dev:clean`.
@sydrosa sydrosa requested review from a team, vpicone and aledavila and removed request for a team March 8, 2021 15:55
@vercel
Copy link

vercel bot commented Mar 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/B9BR4xK9uLTFqDVxbEbP9gEJosQj
✅ Preview: https://gatsby-theme-c-git-fork-sydrosa-patch-1-carbon-design-2a094d.vercel.app

@vpicone vpicone merged commit d855fac into carbon-design-system:main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants