-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust search container width to align with page contents #1105
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/AdSk6Hoh5tLGBLKrBTMFKzie4E6g |
Preview looks good in both desktop and mobile |
@jeanservaas made it so we only expand to 100% when the left nav is hidden. Once we get out of tablet range, it maxes out at the original spec/component implementation. |
Preview looks wrong now? What happened? |
Also seeing this in the preview for “Workplace Design” — https://ibm-brand.github.io/workplace-xg/ |
@mjabbink @aagonzales and @jeanservaas okayed returning to the original search spec on desktop. Because the shell sits above and separate from the page contents, justifying to that content requires hacky approximations at each viewport with unpleasant edge cases (see @alisonjoseph screenshot) |
Reason why it requires hacks: the page container pushes from the left and the search emerges from the right. We also need to subtract the switcher menu which gets spicy. |
Its a theme issue so they'll get a fix once we ship this and they update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In the last image the search is spanning too far. |
Looks good to me too as long as the |
@vpicone @alisonjoseph This seems to have reverted because it’s the same as before the issue was made. |
closes #1101
Adds some media queries to handle search width at various viewports.