Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release shadowing issue #1146

Closed
Palke opened this issue Jul 21, 2021 · 2 comments · Fixed by #1148
Closed

Latest release shadowing issue #1146

Palke opened this issue Jul 21, 2021 · 2 comments · Fixed by #1148

Comments

@Palke
Copy link
Contributor

Palke commented Jul 21, 2021

There seems to be an issue related to the component shadowing (Footer, Header) causing that Shadowed components are ignored and instead default props are rendered.

You can see the issue on currently deployed GTC doc site: https://gatsby.carbondesignsystem.com/

Expected:
image

Current:
image

This issue seems to be related to the v2 GTC as I had the same result updating one of my site.

@vpicone

@vpicone
Copy link
Collaborator

vpicone commented Jul 21, 2021

This issue is also occurring in the Carbon and IDL PRs:
carbon-design-system/carbon-website#2416
carbon-design-system/design-language-website#968

@vpicone
Copy link
Collaborator

vpicone commented Jul 21, 2021

Some solid debugging info from @Palke

Related issues:
gatsbyjs/gatsby#30435
gatsbyjs/gatsby#31389
Tried to alter the "components" location and understand why most of them were working, and few not.

  • Footer.js file
    not working properly
  • Footer folder / Footer.js file
    Crashing browser
  • Footer folder / index.js file
    Working

As this behaviour is a bit different than it was previously it might end up being breaking change with easy fix, just so you could take a look on it and verify my findings.

Tried the same with Header.js file that is not working either now, moving the file into Header folder and changing the file name to index.js did work too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants