Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code guidance for the <Aside> component is wrong #1201

Closed
tomwaterton opened this issue Jan 7, 2022 · 0 comments · Fixed by #1202
Closed

The code guidance for the <Aside> component is wrong #1201

tomwaterton opened this issue Jan 7, 2022 · 0 comments · Fixed by #1202

Comments

@tomwaterton
Copy link

Re the Aside component page:

If a user doesn't want the hanging rule on the aside, they can use the hideRule prop.

Screenshot 2022-01-07 at 11 17 56

However, this prop needs to be added to the <Aside> component, not the <Column> component, so the guidance on this page needs to be updated:

Screenshot 2022-01-07 at 11 15 19

That is, the code shown needs to be updated to this:

<Column colMd={2} colLg={3} offsetMd={1} offsetLg={1}>
<Aside hideRule>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant