Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add first-child rule and add back h1 styles w/ docs #181

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jun 18, 2019

This reverts the style changes to the h1 tag from v1.2.0 in favor of a much more flexible approach to preserving the lead space of content containers. Instead of limiting the starting components, the first child of each page's content container will have it's margin-top removed.

For most pages, we recommend starting with a PageDescription followed by AnchorLinks if the content is long enough.

Note: The title located in each page header is an h1. Some resources suggest you should only have a single h1 per page, while others indicate it doesn't matter. As a rule, we recommend using h2s as section headings for a consistent hierarchy in your markdown.

@vpicone vpicone requested a review from alisonjoseph June 18, 2019 17:48
@vercel
Copy link

vercel bot commented Jun 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-markdown-fix.carbon-design-system.now.sh

@vpicone vpicone merged commit 1b94e85 into carbon-design-system:master Jun 19, 2019
@vpicone vpicone deleted the markdown-fix branch June 19, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants