Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spacing updates / fixes #350

Merged
merged 8 commits into from
Aug 21, 2019
Merged

fix: spacing updates / fixes #350

merged 8 commits into from
Aug 21, 2019

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Aug 16, 2019 •
edited
Loading

Met w/ @jeanservaas to go over spacing for paragraphs, quotes and asides inside of columns.

closes #359

@vercel
Copy link

vercel bot commented Aug 16, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-alisonjoseph-type-spacing-fixes.carbon-design-system.now.sh

@alisonjoseph alisonjoseph requested a review from vpicone August 19, 2019 18:49
@alisonjoseph alisonjoseph changed the title fix: spacing updates / fixes . --WIP fix: spacing updates / fixes Aug 19, 2019
This was referenced Aug 19, 2019
Merged
Closed
vpicone
vpicone reviewed Aug 20, 2019
View reviewed changes
packages/gatsby-theme-carbon/src/components/Aside/Aside.module.scss Outdated
@@ -3,6 +3,7 @@
position: relative;
padding-top: $spacing-04;
top: -$spacing-04;
width: 84%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t really remember where this value came from, can we handle this with padding so we don’t need to target individual elements (like the p’s below). Sometimes I think it’s helpful to assume that the component isn’t being used with mdx. Can we guarantee the internal content will be a paragraph?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value came from Jeanne when sitting down next to me, to get design correct. I can move it to padding.

@alisonjoseph
Copy link
Member Author

docs updated

@vercel vercel bot temporarily deployed to staging August 21, 2019 12:14 Inactive
@vercel vercel bot temporarily deployed to staging August 21, 2019 12:15 Inactive
@alisonjoseph alisonjoseph requested a review from vpicone August 21, 2019 12:17
@alisonjoseph alisonjoseph merged commit eb09950 into carbon-design-system:master Aug 21, 2019
@alisonjoseph alisonjoseph deleted the type-spacing-fixes branch August 21, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpicone vpicone Awaiting requested review from vpicone

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
2 participants
@alisonjoseph @vpicone