Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list spacing #351

Merged
merged 2 commits into from
Aug 16, 2019
Merged

fix: list spacing #351

merged 2 commits into from
Aug 16, 2019

Conversation

alisonjoseph
Copy link
Member

closes #341

@vercel
Copy link

vercel bot commented Aug 16, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-alisonjoseph-list-styles.carbon-design-system.now.sh

Copy link
Contributor

@connor-leech connor-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vpicone
Copy link
Contributor

vpicone commented Aug 16, 2019

@alisonjoseph this might also be a result of us re-importing the list styles so let's see if removing the double import fixes it.

@alisonjoseph
Copy link
Member Author

@vpicone we still need to remove the margin-bottom, but we should be able to remove the global style

@vpicone vpicone merged commit 05a753a into carbon-design-system:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(list): Unordered lists spaced incorrectly
3 participants