Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeftNav/Tabs active selection bugs #386

Closed
tay1orjones opened this issue Aug 29, 2019 · 6 comments · Fixed by #819
Closed

LeftNav/Tabs active selection bugs #386

tay1orjones opened this issue Aug 29, 2019 · 6 comments · Fixed by #819
Assignees

Comments

@tay1orjones
Copy link
Member

Continuing problems we're seeing with the left nav selection states:

1. Duplicate selection when page names are similar (similar to #44)

  • image

2. Single pages with tabs lose left nav selection when a tab non-first tab is selected (similar to #168)

  • First tab selected, has appropriate active state:
    image

  • Second tab selected, does not have appropriate active state:
    image

@eng618
Copy link
Collaborator

eng618 commented Sep 16, 2019

Same issue occurs when there is a subfolder in pages/. i.e. pages/notes/myNewNote

The nav will be created but, the entire section is active as below image depicts

image

@vpicone
Copy link
Contributor

vpicone commented Dec 9, 2019

@eng618 is this still an issue for you? We made some changes to the way these are handled.

@eng618
Copy link
Collaborator

eng618 commented Dec 10, 2019

@vpicone no seems to be resolved.

@vpicone vpicone closed this as completed Dec 10, 2019
@SimonFinney
Copy link

@vpicone I've observed this issue still existing when pages are named the same, but fall under separate sections - here's an example of it on the Carbon Design System:

Nav

@vpicone
Copy link
Contributor

vpicone commented Apr 16, 2020

Ah the issue that never ends thank you @SimonFinney will take a look at it!

@tay1orjones
Copy link
Member Author

We're also experiencing an issue where tabbed pages get sent to 404 occasionally when the titles are similar. This is for https://pages.github.ibm.com/ai-applications/design/

Here's the bug report, ai-applications/design#8:

To recreate:
Open this page - https://pages.github.ibm.com/ai-applications/design/team/tools-and-resources/tools
Click on Resources tab
Click on Tools tab = 404 - it's pointing to https://pages.github.ibm.com/ai-applications/design/team/tools-**and-tools**/resources/
Designer toolkit doesn't work either. https://pages.github.ibm.com/ai-applications/design/team/tools-**and-designer-toolkit**/resources/

Is appending the wrong url to the tab link for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants