feat(Grid): Added xl and max #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/iumxx65jt |
ghost
requested review from
abbeyhrt and
asudoh
and removed request for
a team
alisonjoseph
requested changes
Oct 24, 2019
| | colMd | number | | | Specify the col width at medium breakpoint | | ||
| | colLg | number | | 12 | Specify the col width at large breakpoint | | ||
| | colXl | number | | 12 | Specify the col width at x-large breakpoint | | ||
| | colMax | number | | 12 | Specify the col width at max breakpoint | |
There was a problem hiding this comment.
should colMax and colXL have the default as 12 here? Its not set in the code
Co-Authored-By: Alison Joseph <alisonejoseph@Gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added xl and max to the Grid.