Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureCard has nested anchors #517

Closed
techtolentino opened this issue Nov 13, 2019 · 2 comments · Fixed by #518
Closed

FeatureCard has nested anchors #517

techtolentino opened this issue Nov 13, 2019 · 2 comments · Fixed by #518
Labels
severity: 4 Affects minor functionality, no workaround needed type: bug 🐛

Comments

@techtolentino
Copy link

The FeatureCard component has nested anchors

When implementing the <FeatureCard> component, I noticed a warning in the console that says Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>.

What browser are you working in?
Chrome, Version 78.0.3904.97 (Official Build) (64-bit)

Steps to reproduce the issue

  1. import FeatureCard
  2. implement the thing
  3. give it an href
  4. peep the console

Screenshot

anchor_descendent_of_anchor

featurecard_browser_console

❤️ the work y'all do

✊
@jendowns
Copy link
Contributor

Hey everyone, I have an idea to fix this & can open a PR shortly 👍

@jendowns jendowns mentioned this issue Nov 13, 2019
Merged
@jnm2377
Copy link
Contributor

jnm2377 commented Nov 15, 2019

@jendowns thanks for jumping in! Look forward to seeing your PR!

@jnm2377 jnm2377 added priority: medium severity: 4 Affects minor functionality, no workaround needed labels Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity: 4 Affects minor functionality, no workaround needed type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(feature-card): don't provide FeatureCard's href to ResourceC…
3 participants
@techtolentino @jendowns @jnm2377