Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caption spacing update #613

Closed
mjabbink opened this issue Dec 14, 2019 · 4 comments · Fixed by #628
Closed

caption spacing update #613

mjabbink opened this issue Dec 14, 2019 · 4 comments · Fixed by #628

Comments

@mjabbink
Copy link
Contributor

mjabbink commented Dec 14, 2019

In one of the caption (below) there is an extra 4px or so under the image which is adding additional space above caption. This extra space under image should be removed.
https://gatsby-theme-carbon.now.sh/components/Caption#example

Screen Shot 2019-12-14 at 3 52 49 PM

Other examples in IDL site

Screen Shot 2019-12-14 at 3 48 55 PM

————

Screen Shot 2019-12-14 at 3 47 32 PM

————

Screen Shot 2019-12-14 at 3 45 42 PM

@alisonjoseph
Copy link
Member

@vpicone can this be closed w/ your latest caption fix?

@jnm2377
Copy link
Contributor

jnm2377 commented Jan 7, 2020

Ah, looks like this issue is coming from the image. I thought this was just happening in the IDL site and had opened a PR there in December (https://github.com/jnm2377/design-language-website/blob/3649a124dc933f594985d85cb6257bca86333676/src/styles/_images.scss#L14)

Will add the display: block for images in Gatsby as well. I think that should do it.

@jnm2377 jnm2377 self-assigned this Jan 7, 2020
@jnm2377
Copy link
Contributor

jnm2377 commented Jan 7, 2020

fyi, I think the problem with those images in the IDL site is that they aren't in a row, so it's not receiving the styles I added. It seems some of the images are wrapped in a row container and some aren't, so it probably would have been better to just make the img styles as generic as possible. Either way, I can add them to the gatsby theme instead.

@mjabbink
Copy link
Contributor Author

mjabbink commented Jan 8, 2020

The first image sample is from Gatsby them site not just IDL site. It is happening across the them sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants