-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caption spacing update #613
Comments
@vpicone can this be closed w/ your latest caption fix? |
Ah, looks like this issue is coming from the image. I thought this was just happening in the IDL site and had opened a PR there in December (https://github.com/jnm2377/design-language-website/blob/3649a124dc933f594985d85cb6257bca86333676/src/styles/_images.scss#L14) Will add the |
fyi, I think the problem with those images in the IDL site is that they aren't in a row, so it's not receiving the styles I added. It seems some of the images are wrapped in a row container and some aren't, so it probably would have been better to just make the img styles as generic as possible. Either way, I can add them to the gatsby theme instead. |
The first image sample is from Gatsby them site not just IDL site. It is happening across the them sites. |
In one of the caption (below) there is an extra 4px or so under the image which is adding additional space above caption. This extra space under image should be removed.
https://gatsby-theme-carbon.now.sh/components/Caption#example
Other examples in IDL site
————
————
The text was updated successfully, but these errors were encountered: