Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mobile block quote indent and hanging quote closes #615 #631

Merged
merged 2 commits into from
Jan 8, 2020
Merged

fix: add mobile block quote indent and hanging quote closes #615 #631

merged 2 commits into from
Jan 8, 2020

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented Jan 7, 2020 •
edited
Loading

Switches to text-indent for hanging quotes. Adds 16px margin left on mobile.

closes #630

@vercel
Copy link

vercel bot commented Jan 7, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/96ayb2gee
✅ Preview: https://gatsby-theme-carbon-git-fork-vpicone-mobile-block-quote.carbon-design-system.now.sh

jnm2377
jnm2377 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jeanservaas
jeanservaas approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile indent looks good, I need to make another issue for some other wonkiness on the page that mike mentioned.

@jeanservaas jeanservaas merged commit 467709a into carbon-design-system:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanservaas jeanservaas jeanservaas approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

@mjabbink mjabbink Awaiting requested review from mjabbink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[blockquote]: add mobile blockquote indent and hanging quote
3 participants
@vpicone @jnm2377 @jeanservaas