Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aside): mobile view #635

Merged
merged 6 commits into from
Jan 8, 2020

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Jan 8, 2020

Closes #574

Aside component overlaps body copy in mobile view when it should actually just go away all together per design specs.

Changed

  • removes aside in sm breakpoints

@jnm2377 jnm2377 requested review from jeanservaas and a team January 8, 2020 17:27
@vercel
Copy link

vercel bot commented Jan 8, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/j0evti5or
✅ Preview: https://gatsby-theme-carbon-git-fork-jnm2377-fix-aside-mobile.carbon-design-system.now.sh

Copy link
Contributor

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you!

@vpicone vpicone merged commit fc4e206 into carbon-design-system:master Jan 8, 2020
@ghost ghost requested review from abbeyhrt and sstrubberg January 8, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Aside]: component overlaps sibling columns on small viewports
3 participants