fix(NextPrev): offset and hompage conditions #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstrubberg
requested review from
a team,
vpicone and
jnm2377
and removed request for
a team
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/2c647mpad |
sstrubberg
changed the title
vpicone
suggested changes
Mar 5, 2020
packages/gatsby-theme-carbon/src/components/NextPrevious/NextPrevious.js
Outdated
Show resolved
Hide resolved
sstrubberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #746
Now with 90% less commit garbage ;)
Added logic and style for the first button to be hidden if it's the homepage, thus giving the offset.
Blocker: It thinks every page is the homepage, displaying the next, but hiding the previous.