Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 791-header-shell-links-removing-left-nav #848

Merged
merged 44 commits into from
Jun 18, 2020
Merged

feat: 791-header-shell-links-removing-left-nav #848

merged 44 commits into from
Jun 18, 2020

Conversation

andreancardona
Copy link
Contributor

Closes #791

@andreancardona andreancardona requested review from a team, vpicone and jnm2377 and removed request for a team May 20, 2020 20:36
@vercel
Copy link

vercel bot commented May 20, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/oxsvj1x38
✅ Preview: https://gatsby-theme-c-git-fork-andreancardona-791-header-shell-a97073.carbon-design-system.vercel.app

@vercel vercel bot temporarily deployed to Preview May 20, 2020 20:36 Inactive
@andreancardona andreancardona marked this pull request as draft May 20, 2020 20:36
@andreancardona andreancardona changed the title feat: 791 header shell links removing left nav feat: #791 header shell links removing left nav May 20, 2020
vpicone
vpicone reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome, a couple minor things. I'd like for the hasHeaderNavigation to be useHeaderNavigation and have it be a theme option folks can pass into their config. Let me know if you wanna work together on it!

packages/gatsby-theme-carbon/src/components/HeaderNav/HeaderNav.js Outdated Show resolved Hide resolved
packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavWrapper.module.scss Outdated Show resolved Hide resolved
@andreancardona andreancardona self-assigned this May 28, 2020
@andreancardona andreancardona changed the title feat: #791 header shell links removing left nav feat: 791 header shell links removing left nav May 28, 2020
@andreancardona andreancardona changed the title feat: 791 header shell links removing left nav feat: 791-header-shell-links-removing-left-nav May 28, 2020
@andreancardona andreancardona marked this pull request as ready for review May 29, 2020 15:23
vpicone
vpicone suggested changes May 29, 2020
View reviewed changes
packages/example/gatsby-config.js Outdated Show resolved Hide resolved
vpicone
vpicone reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, I think we can remove the option from the example now so it's back to the default.

@vercel vercel bot temporarily deployed to Preview June 16, 2020 15:08 Inactive
@andreancardona
Copy link
Contributor Author

Looking great, I think we can remove the option from the example now so it's back to the default.

done!

@vercel vercel bot temporarily deployed to Preview June 16, 2020 19:09 Inactive
vpicone
vpicone reviewed Jun 16, 2020
View reviewed changes
Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove prop drilling pls

@vercel vercel bot temporarily deployed to Preview June 16, 2020 21:44 Inactive
@vpicone
Copy link
Contributor

vpicone commented Jun 17, 2020

Awesome work, you crushed it!

@andreancardona andreancardona merged commit 38a9a2b into carbon-design-system:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@vpicone vpicone vpicone approved these changes

Assignees

@andreancardona andreancardona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guidance for header shell links and removing left nav (like /design)
4 participants
@andreancardona @jnm2377 @vpicone @sstrubberg