Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Programatically set the max-height for the switcher nav #856

Closed
vpicone opened this issue May 28, 2020 · 1 comment · Fixed by #870
Closed

Programatically set the max-height for the switcher nav #856

vpicone opened this issue May 28, 2020 · 1 comment · Fixed by #870
Assignees
@jnm2377

Comments

@vpicone
Copy link
Contributor

vpicone commented May 28, 2020 •
edited
Loading

Given users can replace Switcher content with their own, and we are semi-frequently modifying Switcher content ourselves, we should opt for a more automated solution to animating the Switcher height.

One solution would be to use a DOM ref on the list and measure it's height, using this value to calculate the max-height of the nav wrapping it.
@vpicone
Copy link
Contributor Author

vpicone commented May 28, 2020

This doesn't have to be in the current PR, but should improve the flexibility of the Switcher quite a bit.

@vpicone vpicone changed the title Programatically set the max-height for the switcher Switcher updates May 28, 2020
@vpicone vpicone changed the title Switcher updates Programatically set the max-height for the switcher nav May 28, 2020
@jnm2377 jnm2377 mentioned this issue Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnm2377 jnm2377

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vpicone @jnm2377