Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to add divider to side nav #885

Merged
merged 9 commits into from
Jun 26, 2020
Merged

feat: ability to add divider to side nav #885

merged 9 commits into from
Jun 26, 2020

Conversation

xylish7
Copy link
Contributor

@xylish7 xylish7 commented Jun 23, 2020

Closes #865

Ability to add divider to side nav items.

Changelog

New

  • adding hasDivider: true in nav-items.yaml to the nav list item will add a divider below that item

@xylish7 xylish7 requested review from a team, sstrubberg and andreancardona and removed request for a team June 23, 2020 15:44
@vercel
Copy link

vercel bot commented Jun 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/ef0wl3s87
✅ Preview: https://gatsby-theme-carbon-git-fork-xylish7-filip-frincu-patch-1.carbon-design-system.vercel.app

@xylish7 @sstrubberg
feat: update documentation related to divider useage
7eb11b4 
Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
@sstrubberg sstrubberg self-requested a review June 25, 2020 15:49
@xylish7 @sstrubberg
fix typo in documentation
853d6ff 
Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com>
andreancardona
andreancardona approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @xylish7 :)

vpicone
vpicone approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job with both the planning and execution here. The right solution done the right way. Thanks @xylish7!

packages/example/src/pages/guides/navigation/sidebar.mdx Outdated Show resolved Hide resolved
@xylish7 @vpicone
feate: update divider documentation title
8329692 
Co-authored-by: Vince Picone <vpicone@gmail.com>
@xylish7
Copy link
Contributor Author

xylish7 commented Jun 26, 2020

Thank you! Happy that I can contribute. 😀

@vpicone vpicone changed the title ability to add divider to side nav feat: ability to add divider to side nav Jun 26, 2020
@vpicone vpicone merged commit a9bb04e into carbon-design-system:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

@vpicone vpicone vpicone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Ability to use dividers in side navigation
4 participants
@xylish7 @vpicone @sstrubberg @andreancardona