Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ResourceCard-FeatureCard): icon was the wrong color #891

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jun 24, 2020

Closes #883

Targeted the SVG in the ResourceCard and gave it icon-01. Update the FeatureCard docs to have one feature card using the default color and one feature card using dark mode.

@sstrubberg sstrubberg requested review from a team, vpicone and jnm2377 and removed request for a team June 24, 2020 20:43
@vercel
Copy link

vercel bot commented Jun 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/f9tr9adec
✅ Preview: https://gatsby-theme-carbon-git-fork-sstrubberg-resourcecard-link.carbon-design-system.vercel.app

Copy link
Contributor

@vpicone vpicone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think carbon recently set the default icon color to be currentcolor. Since we very specifically only define the color of the title/subtitle, the svg gets the default anchor link color. I like that this implementation mirrors the dark one. Nice work!

@vpicone vpicone merged commit ccd0a46 into carbon-design-system:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons in the FeatureCard have became blue
2 participants