Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private interfaces in public API files #971

Closed
josh11b opened this issue Dec 7, 2021 · 6 comments
Closed

Private interfaces in public API files #971

josh11b opened this issue Dec 7, 2021 · 6 comments
Labels
leads question A question for the leads team

Comments

@josh11b
Copy link
Contributor

josh11b commented Dec 7, 2021

This is a question from #931 :
Should we allow a private interface to be declared in an API file to be referenced in a public named constraint available to users?

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

We triage inactive PRs and issues in order to make it easier to find active work. If this issue should remain active or becomes active again, please comment or remove the inactive label. The long term label can also be added for issues which are expected to take time.
This issue is labeled inactive because the last activity was over 90 days ago.

@github-actions github-actions bot added the inactive Issues and PRs which have been inactive for at least 90 days. label Mar 8, 2022
@chandlerc chandlerc removed the inactive Issues and PRs which have been inactive for at least 90 days. label Mar 29, 2022
@chandlerc
Copy link
Contributor

What are the tradeoffs of allowing this vs. disallowing? Is there any initial suggested direction here or context?

@josh11b
Copy link
Contributor Author

josh11b commented Mar 31, 2022

I think this issue should probably be deferred until this issue becomes more pressing.

@josh11b
Copy link
Contributor Author

josh11b commented Apr 1, 2022

On second thought, I think we should allow this. We already have an example in #1154 of things that can be used as requirements but can't be implemented, and requiring a private interface to be implemented would be a straightforward way to construct such a thing. This would be consistent with what we've already designed and not really a new feature.

@chandlerc
Copy link
Contributor

Leads seem good here too, let's call this decided as "yes we should allow this" as @josh11b's comment indicates.

@jonmeow
Copy link
Contributor

jonmeow commented Aug 11, 2022

Filed #2003 to track the need for a proposal here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
leads question A question for the leads team
Projects
None yet
Development

No branches or pull requests

3 participants