Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change emoji for code review changes #462

Closed
mattfrankjames opened this issue Jun 17, 2020 · 5 comments · Fixed by #463
Closed

Change emoji for code review changes #462

mattfrankjames opened this issue Jun 17, 2020 · 5 comments · Fixed by #463
Labels
breaking-change emoji Gitmoji proposals.

Comments

@mattfrankjames
Copy link

mattfrankjames commented Jun 17, 2020

Hello @carloscuesta 😎!

I already opened a PR (jumped the gun a little there), but it seems like it might be worth changing the code review suggestion emoji to something other than the ok hand as that has been co-opted by white nationalists.

  • Emoji: 👀 :
  • Code: :eyes:
  • Description:
    Eyes imply that someone has looked at the code to review it so it seems like an appropriate emoji.

There are well documented issues with the ok hand and changing that emoji could eliminate a potential trigger for some and make this project more inclusive.

Related with #461

@carloscuesta
Copy link
Owner

Hey @mattfrankjames

I have no problem on changing the emoji if this makes the project more inclusive.

But I would like to know more about this assumption:

The ok hand as that has been co-opted by white nationalists.

According to the emojipedia, this is not exactly true and seems that there is a misconception about this emoji:

https://blog.emojipedia.org/no-the-ok-hand-is-not-a-symbol-of-white-power/

Could you provide more information about this ?

Thanks,

@carloscuesta carloscuesta added breaking-change emoji Gitmoji proposals. labels Jun 17, 2020
@johannchopin
Copy link
Collaborator

Here's a theme I'm always wondering about. Why make things worse than they are? Certainly some people have used this gesture as a racist sign but for all that will have to completely change the meaning of it? If tomorrow the white nationalists shake hands as a sign of supremacy will we all stop shaking hands?

I am of the opinion that ancestral symbols should not be tarnished by a few people.

Lets just keep 👌 since it's an ok hand

@mattfrankjames
Copy link
Author

mattfrankjames commented Jun 17, 2020

@carloscuesta The Anti Defamation League has recently designated this as a symbol of hate. Obviously, it is not definitively a symbol hate in all contexts and it's not fair to assume that someone using it is a white nationalist, but the potential is there. Certainly, there was a lot of uproar about it on Twitter during the so called "React-gate" last year. Here are some links.
NPR Article
Anti-Defamation Leage post
Southern Poverty Law Center post
Business Insider rundown of #reactgate
Truth be told, I would love to keep using that emoji and symbol in general in my day to day life, but with the implications somewhat murky these days... I've stopped. This issue is more of a suggestion than anything.

@mattfrankjames
Copy link
Author

@johannchopin , I agree with you conceptually. I brought it up because it is a sensitive subject for some under-represented developers and designers, which I think is worth considering.

@vhoyer vhoyer linked a pull request Jun 18, 2020 that will close this issue
@vhoyer
Copy link
Collaborator

vhoyer commented Jun 18, 2020

You know, we are discussing the removal of this emoji on #348, maybe we can post-pone this PR until we are set on whether we are removing it or not 🤔

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change emoji Gitmoji proposals.
Projects
None yet
4 participants