-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internet explorer compatibility broken #44
Comments
Good catch, thanks for opening the issue. I didn't really have any plans of supporting IE (unpopular opinion, I know) but if this is the only pain point to make it work in IE then I'll look into it and fix it in the next patch. Thanks again for noting it! |
Thanks. I'm glad to hear that and yes, it is the only thing that prevents notyf from working in IE11. After I polyfilled |
You can just put this in a file and use it, I guess. |
@caroso1222 would you accept a PR on this? I'll just implement the old way of finding an index instead of a modern "findIndex" method to make it usable without any polyfills. |
Hey @terales. Sorry for the late reply, still coming back from holidays. Yeah definitely, thanks! Take a stab at it and I'll review the PR. |
@mdix can you prepare a PR, please? I'm on Ubuntu since January and it seems that I would be without available Windows machine for a while now. |
Fixed it already. Thank you all for the help! 😃 |
Using
findIndex
w/o polyfilling breaks notyf in all available Internet Explorers.Usage:
notyf/src/notyf.ts
Line 73 in 694728e
Error in Internet Explorer:
The text was updated successfully, but these errors were encountered: