Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming "blacklist/whitelist" methods to something else #2491

Closed
rhymes opened this issue Jun 8, 2020 · 1 comment
Closed

Consider renaming "blacklist/whitelist" methods to something else #2491

rhymes opened this issue Jun 8, 2020 · 1 comment

Comments

@rhymes
Copy link
Contributor

rhymes commented Jun 8, 2020

Following the example of rails/rails#33677 and forem/forem#7147 I'm proposing to take into consideration the replacement of words like whitelist/blacklist from carrierwave's source code.

Possible alternatives: allow/deny, valid/invalid, permitted/blocked

According to a quick search - https://github.com/carrierwaveuploader/carrierwave/search?q=blacklist+OR+whitelist&unscoped_q=blacklist+OR+whitelist - there are a few instances of this.

A possible solution would be to add alternative methods and deprecation notices and then remove them a couple of releases down the line or something like that.

I can work on the initial PR if agreed.

Thank you!

@mshibuya
Copy link
Member

mshibuya commented Feb 21, 2021

Closed by #2442.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants