Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialized via build()? #58

Open
jGaboardi opened this issue Jun 22, 2024 · 2 comments
Open

initialized via build()? #58

jGaboardi opened this issue Jun 22, 2024 · 2 comments
Assignees
Labels

Comments

@jGaboardi
Copy link
Collaborator

jGaboardi commented Jun 22, 2024

The conga line structure must have min_points to be initialized from the FastPair class. However, when an instance is created via FastPair.build() there is no assumption any min_points.

Should we perhaps throw a warning if min_points are not yet met when calling .build()?

Also, here in test_iter().

@carsonfarmer
Copy link
Owner

Yes good point, for consistency, it should probably be throwing a warning or error.

@jGaboardi
Copy link
Collaborator Author

I think a warning is best since there is sound logic for simply doing the brute-force when min_points aren't met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants