-
-
Notifications
You must be signed in to change notification settings - Fork 18
/
no-misused-generics.ts
156 lines (148 loc) · 4.94 KB
/
no-misused-generics.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
/**
* @license Use of this source code is governed by an MIT-style license that
* can be found in the LICENSE file at https://github.com/cartant/eslint-plugin-etc
* Portions of this file are copyright 2017 Klaus Meinhardt - see THIRD_PARTY_NOTICES.
*/
/* eslint @typescript-eslint/no-non-null-assertion: "off" */
import { TSESTree as es } from "@typescript-eslint/experimental-utils";
import { getLoc, getParserServices } from "eslint-etc";
import * as tsutils from "tsutils";
import * as ts from "typescript";
import { ruleCreator } from "../utils";
const rule = ruleCreator({
defaultOptions: [],
meta: {
docs: {
description:
"Forbids type parameters without inference sites and type parameters that don't add type safety to declarations.",
recommended: false,
},
fixable: undefined,
hasSuggestions: false,
messages: {
canReplace:
"Type parameter '{{name}}' is not used to enforce a constraint between types and can be replaced with '{{replacement}}'.",
cannotInfer:
"Type parameter '{{name}}' cannot be inferred from any parameter.",
},
schema: [],
type: "problem",
},
name: "no-misused-generics",
create: (context) => {
const { esTreeNodeToTSNodeMap } = getParserServices(context);
let usage: Map<ts.Identifier, tsutils.VariableInfo> | undefined;
function checkSignature(node: es.Node) {
const tsNode = esTreeNodeToTSNodeMap.get(node);
if (
tsutils.isSignatureDeclaration(tsNode) &&
tsNode.typeParameters !== undefined
) {
checkTypeParameters(tsNode.typeParameters, tsNode);
}
}
function checkTypeParameters(
typeParameters: readonly ts.TypeParameterDeclaration[],
signature: ts.SignatureDeclaration
) {
if (usage === undefined) {
usage = tsutils.collectVariableUsage(signature.getSourceFile());
}
outer: for (const typeParameter of typeParameters) {
let usedInParameters = false;
let usedInReturnOrExtends = tsutils.isFunctionWithBody(signature);
for (const use of usage.get(typeParameter.name)!.uses) {
if (
use.location.pos > signature.parameters.pos &&
use.location.pos < signature.parameters.end
) {
if (usedInParameters) {
continue outer;
}
usedInParameters = true;
} else if (!usedInReturnOrExtends) {
usedInReturnOrExtends =
use.location.pos > signature.parameters.end ||
isUsedInConstraint(use.location, typeParameters);
}
}
if (!usedInParameters) {
context.report({
data: {
name: typeParameter.name.text,
},
loc: getLoc(typeParameter),
messageId: "cannotInfer",
});
} else if (
!usedInReturnOrExtends &&
!isConstrainedByOtherTypeParameter(typeParameter, typeParameters)
) {
context.report({
data: {
name: typeParameter.name.text,
replacement: typeParameter.constraint
? typeParameter.constraint.getText(signature.getSourceFile())
: "unknown",
},
loc: getLoc(typeParameter),
messageId: "canReplace",
});
}
}
}
function isConstrainedByOtherTypeParameter(
current: ts.TypeParameterDeclaration,
all: readonly ts.TypeParameterDeclaration[]
) {
if (current.constraint === undefined) {
return false;
}
for (const typeParameter of all) {
if (typeParameter === current) {
continue;
}
for (const use of usage!.get(typeParameter.name)!.uses) {
if (
use.location.pos >= current.constraint.pos &&
use.location.pos < current.constraint.end
) {
return true;
}
}
}
return false;
}
function isUsedInConstraint(
use: ts.Identifier,
typeParameters: readonly ts.TypeParameterDeclaration[]
) {
for (const typeParameter of typeParameters) {
if (
typeParameter.constraint !== undefined &&
use.pos >= typeParameter.constraint.pos &&
use.pos < typeParameter.constraint.end
) {
return true;
}
}
return false;
}
return {
ArrowFunctionExpression: checkSignature,
FunctionDeclaration: checkSignature,
FunctionExpression: checkSignature,
MethodDefinition: checkSignature,
"Program:exit": () => (usage = undefined),
TSCallSignatureDeclaration: checkSignature,
TSConstructorType: checkSignature,
TSConstructSignatureDeclaration: checkSignature,
TSDeclareFunction: checkSignature,
TSFunctionType: checkSignature,
TSIndexSignature: checkSignature,
TSMethodSignature: checkSignature,
TSPropertySignature: checkSignature,
};
},
});
export = rule;