moved proof parser to crate, added proof as felts #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piniom
reviewed
Sep 19, 2024
| /// It provides convenience methods for working with a vector of `Arg` and implements | ||
| /// `Deref` to allow it to be treated like a vector of `Arg`. | ||
| #[derive(Debug, Clone)] | ||
| pub struct VecFelt(Vec<Felt>); |
There was a problem hiding this comment.
Why Arg here, where the type is Felt?
| impl<'de> Visitor<'de> for VecFelt { | ||
| type Value = VecFelt; | ||
| fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
| formatter.write_str("a list of arguments") |
There was a problem hiding this comment.
Maybe add a more elaborate expectation?
| } | ||
|
|
||
| impl VecFelt { | ||
| fn visit_seq_helper(seq: &[Value]) -> Result<Self, VecFeltError> { |
There was a problem hiding this comment.
This seems a bit complicated, I suggest creating an enum that would be easily deserializable and adding a converter function to VecFelt. The logic will remain the same but the intent would be much clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included proof parsing to felt from https://github.com/HerodotusDev/integrity/tree/main/runner/src
and changed there Felt252 from cairo-felt to Felt from starknet_types_core