Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kctrl: disallow use of shared namespaces while installing packages #672

Closed
2 tasks
100mik opened this issue May 10, 2022 · 2 comments · Fixed by #757
Closed
2 tasks

kctrl: disallow use of shared namespaces while installing packages #672

100mik opened this issue May 10, 2022 · 2 comments · Fixed by #757
Assignees
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli enhancement This issue is a feature request

Comments

@100mik
Copy link
Contributor

100mik commented May 10, 2022

Describe the problem/challenge you have
kctrl should not allow installation of packages into shared namespaces

Describe the solution you'd like
This could be disabled by default and we could add a dangerous flag overriding this behaviour.

Anything else you would like to add:

  • disallow use of shared namespaces for installation
  • Add a flag which accepts comma seperated values where packages can be installed to override this behaviour, similar to --dangerous-allow-use-of-shared-namespace=default,kube-public

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@100mik 100mik added enhancement This issue is a feature request carvel-triage This issue has not yet been reviewed for validity labels May 10, 2022
@100mik
Copy link
Contributor Author

100mik commented May 10, 2022

@cppforlife could you elaborate between the motivation behind this? And how this helps?
Thanks!

@100mik 100mik added cli Issue for kapp-controller cli carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels May 10, 2022
@100mik 100mik mentioned this issue May 10, 2022
62 tasks
@100mik 100mik added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label May 10, 2022
@100mik 100mik self-assigned this May 10, 2022
@cppforlife
Copy link
Contributor

we want to discourage users from using default namespace since it's not a good idea to keep sensitive configurations (service accounts, PackageInstall configuration, etc) in it. (it's commonly seen as a "shared" namespace.)

@100mik 100mik removed the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed cli Issue for kapp-controller cli enhancement This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants