Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kapp delete change should precondition on uid when waiting for resource to be gone #229

Closed
cppforlife opened this issue Jun 14, 2021 · 2 comments · Fixed by #296
Closed
Assignees
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

Describe the problem/challenge you have

currently kapp when waiting for resource to be fully deleted off cluster, ignores that resource might have changed its uid. when uid changes it implies that resource has been deleted, and replaced by a different resource with a same name.

Describe the solution you'd like

we should probably check on uid difference and see that if resource uid changed, then consider it as deleted. there is a nuance in this change though, we should probably continue waiting for the resource to be gone if uid changed, but resource still matches criteria for being within the app (currently happens today).

Anything else you would like to add:

this came up during following steps:

  • with kapp-controller 0.20.0-rc.1
  • add pkg repo to a default ns
  • add pkg repo to global packaging ns
  • delete pkg repo from a default ns (this hangs for default wait timeout) because deleted package was replaced by package that is derived from global ns

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@cppforlife cppforlife added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Jun 14, 2021
@aaronshurley
Copy link
Contributor

This seems like a reasonable change or at least something to explore further. I'm going to move this to carvel accepted so that we can further discuss if/when to prioritize this.

@aaronshurley aaronshurley added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels Jul 14, 2021
@renuy renuy linked a pull request Aug 30, 2021 that will close this issue
@renuy
Copy link
Contributor

renuy commented Sep 23, 2021

release v0.40.0

@github-actions github-actions bot added the carvel triage This issue has not yet been reviewed for validity label Sep 23, 2021
@aaronshurley aaronshurley removed the carvel triage This issue has not yet been reviewed for validity label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants