Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving release process to goreleaser in 0.54.x #708

Closed
wants to merge 1 commit into from

Conversation

rohitagg2020
Copy link
Contributor

Moving release process to goreleaser in 0.54.x

Signed-off-by: rohitagg2020 rohit.aggarwal2020@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: rohitagg2020 <rohit.aggarwal2020@gmail.com>
@rohitagg2020 rohitagg2020 marked this pull request as ready for review February 14, 2023 10:50
@praveenrewar
Copy link
Member

@rohitagg2020 Do we still need this PR, can we resolve the conflicts if it's still required?

Copy link

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@praveenrewar praveenrewar deleted the v0.54.x-ra-fix-goreleaser branch April 29, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants