Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign release artifacts using cosign #877

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

prashantrewar
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #827

Does this PR introduce a user-facing change?

NONE

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@prashantrewar prashantrewar marked this pull request as ready for review December 27, 2023 07:21
@rcmadhankumar
Copy link
Contributor

@prashantrewar , Have you made any downstream releases to verify this workflow?

@prashantrewar
Copy link
Contributor Author

hey @rcmadhankumar, yes i made downstream releases to verify this workflow, here is the release and workflow.

@rcmadhankumar
Copy link
Contributor

LGTM

Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@kumaritanushree
Copy link
Contributor

LGTM

@praveenrewar praveenrewar merged commit b494b67 into carvel-dev:develop Jan 18, 2024
5 checks passed
@prashantrewar prashantrewar deleted the sign-artifacts branch January 18, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sign kapp binaries while releasing them
4 participants